Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Upgrade deck.gl@8.4.11 luma.gl@8.4.3 loaders.gl@2.3.12 #1674

Merged
merged 6 commits into from Jul 20, 2022

Conversation

heshan0131
Copy link
Contributor

  • fix grid and hexagon layer, added tests
  • added test-headless and moved map-container tests there
    Signed-off-by: Shan He heshan0131@gmail.com

[Bug] Fix cpu-aggregator can't access index of undefined

Signed-off-by: Shan He heshan0131@gmail.com

[Bug] Pinning a tooltip moves it to the top left of the screen

  • fix grid and hexagon layer, added tests
  • added test-headless and moved map-container tests there

Copy link
Collaborator

@igorDykhta igorDykhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heshan0131 I added fixes for line altitude and aggregation layers.
Did some testing after that, looks fine.

I've only managed to somehow make hovering not working one time, but cant repro again.

src/layers/aggregation-layer.js Outdated Show resolved Hide resolved
src/layers/index.d.ts Outdated Show resolved Hide resolved
@igorDykhta igorDykhta force-pushed the 0912-deckgl-8.4 branch 2 times, most recently from 97f2d4d to ce19d0d Compare June 28, 2022 23:56
@@ -35,9 +35,6 @@ jobs:
- name: Install Dependecies
run: yarn

- name: Lint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this why ci is not running test?

heshan0131 and others added 6 commits July 21, 2022 00:39
* fix grid and hexagon layer, added tests
* added `test-headless` and moved map-container tests there
Signed-off-by: Shan He <heshan0131@gmail.com>

[Bug] Fix cpu-aggregator can't access index of undefined

Signed-off-by: Shan He <heshan0131@gmail.com>

[Bug] Pinning a tooltip moves it to the top left of the screen

* fix grid and hexagon layer, added tests
* added `test-headless` and moved map-container tests there

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@heshan0131 heshan0131 merged commit c1e2034 into master Jul 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the 0912-deckgl-8.4 branch July 20, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants