[Feat]: Technical: Translate localization to typescript #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
dariaterekhova-actionengine
approved these changes
Feb 8, 2022
ibgreen
reviewed
Feb 8, 2022
| @@ -21,7 +21,17 @@ | |||
| import React from 'react'; | |||
| import {FormattedMessage} from 'react-intl'; | |||
|
|
|||
| const EnhancedFormattedMessage = props => ( | |||
| type FormattedMessageType = { | |||
There was a problem hiding this comment.
For react components... Replace Type with Props?
Suggested change
| type FormattedMessageType = { | |
| type FormattedMessageProps = { |
There was a problem hiding this comment.
agreed, use EnhancedFormattedMessageProps to match the component name
heshan0131
reviewed
Feb 8, 2022
src/localization/locales.ts
Outdated
| @@ -50,4 +50,7 @@ export const LOCALES = { | |||
| * ``` | |||
| */ | |||
|
|
|||
| export const LOCALE_CODES = Object.keys(LOCALES).reduce((acc, key) => ({...acc, [key]: key}), {}); | |||
| export const LOCALE_CODES: {[key: string]: string} = Object.keys(LOCALES).reduce( | |||
There was a problem hiding this comment.
Add a LocaleCodesType for this constant
heshan0131
approved these changes
Feb 8, 2022
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
delete-merged-branch
bot
deleted the
ms/js_to_ts_convertion_localization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.