[Feat]: Technical: Translate redusers (map-state and map-style) to typescript #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
HeimEndyd
requested review from
ibgreen,
heshan0131 and
dariaterekhova-actionengine
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
heshan0131
reviewed
Feb 23, 2022
| { | ||
| // @ts-expect-error | ||
| payload: {config = {}, options = {}, bounds = null} | ||
| }: { |
There was a problem hiding this comment.
return type of this function should be MapState
heshan0131
approved these changes
Feb 23, 2022
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
| label: string; | ||
| url: string; | ||
| icon: string; | ||
| style?: Object; |
There was a problem hiding this comment.
Please avoid Object and any types for future
dariaterekhova-actionengine
approved these changes
Feb 24, 2022
delete-merged-branch
bot
deleted the
ms/js_to_ts_conversion_redusers_map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.