[Chore]: Technical: Translate base-layer #1746
Conversation
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
src/layers/base-layer.ts
Outdated
| export type VisualChannelDomain = number[] | string[]; | ||
| export type VisualChannelField = Field | null; | ||
|
|
||
| export type LayerConfig = { |
There was a problem hiding this comment.
let's rename this constant from LayerConfig to LayerBaseConfig. And remove all the VisualChannel properties (colorField, colorDomain, colorScale, heightField, heightDomain, heightScale, sizeDomain, sizeScale, sizeField)
Visual channels various per layer, some layer have colorField and strokeColorField, and radiusField, some doesn't have any channels. We can add individual visual channel configs in each layer type. E.g. Point layer can be:
type PointVisualChannelConfig = {
colorField: VisualChannelField;
colorScale: VisualChannelScale;
colorDomain: VisualChannelDomain;
strokeColorField: VisualChannelField;
strokeColorScale: VisualChannelScale;
strokeColorDomain: VisualChannelDomain;
sizeField: VisualChannelField;
sizeScale: VisualChannelScale;
sizeDomain: VisualChannelDomain;
}
type PointLayer = BaseLayerConfig & PointVisualChannelConfigYou can look at each layer's get visualChannels method to see which visual channel this layer has
field: 'strokeColorField',
scale: 'strokeColorScale',
domain: 'strokeColorDomain',means this layer will have strokeColorField, strokeColorScale, strokeColorDomain in its config
src/layers/base-layer.ts
Outdated
| @@ -350,7 +444,7 @@ class Layer { | |||
| * @param field - Selected field | |||
| * @returns {{}} - Column config | |||
| */ | |||
| assignColumn(key, field) { | |||
| assignColumn(key: string, field): LayerColumns { | |||
There was a problem hiding this comment.
(key: string, field: Field): LayerColumns
src/utils/layer-utils.js
Outdated
| @@ -99,10 +99,11 @@ export function getLayerHoverProp({ | |||
| return null; | |||
| } | |||
| const {dataContainer, fields} = datasets[dataId]; | |||
| const data = layer.getHoverData(object, dataContainer, fields); | |||
| const data = layer.getHoverData(object, dataContainer); | |||
There was a problem hiding this comment.
fields should be added to base-layer getHoverData method, instead of removing it here
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
src/layers/base-layer.ts
Outdated
| @@ -523,7 +613,7 @@ class Layer { | |||
| } | |||
|
|
|||
| getLayerColumns() { | |||
| const columnValidators = this.columnValidators || {}; | |||
| const columnValidators = {}; | |||
There was a problem hiding this comment.
this.columnValidators shouldn't be removed. instead can we add it to base layer?
type ColumnValidator = (
column: LayerConfigColumn,
columns: LayerColumns,
allFields: Field[]
) => boolean;
get columnValidators(): {[key: string]: ColumnValidator}
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
delete-merged-branch
bot
deleted the
ms/js_to_ts_convertion/layers/base-layer
branch
No description provided.