[Chore]: Technical: Translate components/common final part #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshan0131
reviewed
Mar 22, 2022
| // TODO: convert the entire component to use hooks in the next PR | ||
| static defaultProps = { |
There was a problem hiding this comment.
is there a reason we can't keep defaultProps? I find it a lot more sane then adding values wherever we deconstruct this.props
There was a problem hiding this comment.
The problem of defaultProps is that typescript doesn't see it. So sometimes I should duplicate it with deconstruction default values... But I'll keep it for the cases where it's not necessary
heshan0131
reviewed
Mar 22, 2022
| @@ -118,8 +124,9 @@ function AnimationControllerFactory() { | |||
| }; | |||
|
|
|||
| _resetAnimtionByTimeStep = () => { | |||
| const {steps = []} = this.props | |||
There was a problem hiding this comment.
default value for steps should null
add below to this function
if (!steps) return;
heshan0131
reviewed
Mar 22, 2022
| @@ -200,7 +207,7 @@ function AnimationControllerFactory() { | |||
| } | |||
|
|
|||
| _nextFrameByTimeStep() { | |||
| const {steps, value} = this.props; | |||
| const {steps = [], value} = this.props; | |||
There was a problem hiding this comment.
same as above default value for steps should be null
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/js_to_ts_convertion_components_common_part2
branch
from
9db42e1
to
ef469dc
Compare
delete-merged-branch
bot
deleted the
dt/js_to_ts_convertion_components_common_part2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daria Terekhova daria.terekhova@actionengine.com