[Chore]: Technical: Translate geojson-layer #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
heshan0131
reviewed
Apr 5, 2022
| wireframe: boolean; | ||
| }; | ||
|
|
||
| export type GeoJsonLayerConfig = Merge< |
There was a problem hiding this comment.
type GeoJsonLayerVisualChannelConfig = LayerColorConfig & LayerStrokeColorConfig
LayerSizeConfig & LayerHeightConfig & LayerRadiusConfigThere was a problem hiding this comment.
What is meant by LayerRadiusConfig?
There was a problem hiding this comment.
You can add this to base-layer
export type LayerRadiusConfig = {
radiusField: VisualChannelField;
radiusDomain: VisualChannelDomain;
radiusScale: VisualChannelScale;
};
heshan0131
reviewed
Apr 5, 2022
| @@ -22,7 +22,7 @@ import wktParser from 'wellknown'; | |||
| import normalize from '@mapbox/geojson-normalize'; | |||
There was a problem hiding this comment.
Please types below to type the functions in this file
import {KeplerTable} from '../../utils';
import {Feature, BBox} from 'geojson';
import {LayerColumns} from '../index';
type GetFeature = (d: any) => Feature;
type GeojsonDataMaps = Array<Feature | null>;
export enum FeatureTypes {
Point = 'Point',
MultiPoint = 'MultiPoint',
LineString = 'LineString',
MultiLineString = 'MultiLineString',
Polygon = 'Polygon',
MultiPolygon = 'MultiPolygon'
}
type FeatureTypeMap = {
[key in FeatureTypes]: boolean;
};
export function parseGeoJsonRawFeature(rawFeature: unknown): Feature | null;
export function getGeojsonDataMaps(
allData: KeplerTable['allData'],
getFeature: GetFeature
): GeojsonDataMaps;
export function getGeojsonBounds(features: Feature[]): BBox | null;
export function getGeojsonFeatureTypes(allFeatures: Feature[]): FeatureTypeMap;
export function parseGeometryFromString(geoString: string): Feature | null;There was a problem hiding this comment.
KeplerTable does not contain property allData
heshan0131
reviewed
Apr 5, 2022
|
|
||
| // access feature properties from geojson sub layer | ||
| export const defaultElevation = 500; | ||
| export const defaultLineWidth = 1; | ||
| export const defaultRadius = 1; | ||
|
|
||
| export default class GeoJsonLayer extends Layer { | ||
| declare config: GeoJsonLayerConfig; | ||
| declare visConfigSettings: GeoJsonVisConfigSettings; | ||
| dataToFeature: {properties?: {radius?: number}}[]; |
There was a problem hiding this comment.
dataToFeature: GeojsonDataMaps See comments in geojson-utils
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
heshan0131
approved these changes
Apr 6, 2022
delete-merged-branch
bot
deleted the
ms/js_to_ts_convertion/layers/geojson-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.