-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore]: Technical: Translate s2-geometry-layer #1765
Merged
HeimEndyd
merged 5 commits into
master
from
ms/js_to_ts_convertion/layers/s2-geometry-layer
Apr 5, 2022
Merged
[Chore]: Technical: Translate s2-geometry-layer #1765
HeimEndyd
merged 5 commits into
master
from
ms/js_to_ts_convertion/layers/s2-geometry-layer
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
HeimEndyd
changed the title
[Chore]: Technical: Translate point-layer s2-geometry-layer
[Chore]: Technical: Translate s2-geometry-layer
Mar 30, 2022
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
heshan0131
approved these changes
Apr 5, 2022
heshan0131
reviewed
Apr 5, 2022
heightRange: [number, number]; | ||
wireframe: boolean; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// should add this to base-layer.ts
export type LayerStrokeColorConfig = {
strokeColorField: VisualChannelField;
strokeColorDomain: VisualChannelDomain;
strokeColorScale: VisualChannelScale;
};
export type S2GeometryLayerVisualChannelConfig = LayerColorConfig &
LayerSizeConfig &
LayerStrokeColorConfig &
LayerHeightConfig;
heshan0131
reviewed
Apr 5, 2022
export type S2GeometryLayerConfig = Merge< | ||
LayerBaseConfig, | ||
{columns: S2GeometryLayerColumnsConfig; visConfig: S2GeometryLayerVisConfig} | ||
>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export type S2GeometryLayerConfig = Merge<
LayerBaseConfig,
{columns: S2GeometryLayerColumnsConfig; visConfig: S2GeometryLayerVisConfig}
> & S2GeometryLayerVisualChannelConfig;
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
delete-merged-branch
bot
deleted the
ms/js_to_ts_convertion/layers/s2-geometry-layer
branch
April 5, 2022 09:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.