[Chore]: Technical: Translate root components to typescript #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariaterekhova-actionengine
force-pushed
the
dt/js_to_ts_convertion_components_root_sp
branch
from
8ab78d0
to
00c5553
Compare
heshan0131
reviewed
Apr 20, 2022
src/components/bottom-widget.tsx
Outdated
|
|
||
| const maxWidth = 1080; | ||
|
|
||
| const BottomWidgetContainer = styled.div` | ||
| interface BottomWidgetContainer { |
There was a problem hiding this comment.
type should have Props in its name, so it won't be conversion when exporting both the component and the type of its prop
interface BottomWidgetContainerProps {
hasPadding?: boolean;
width: number
}
heshan0131
reviewed
Apr 20, 2022
src/components/bottom-widget.tsx
Outdated
| export function FilterAnimationControllerFactory( | ||
| AnimationController: ReturnType<typeof AnimationControllerFactory> | ||
| ) { | ||
| const FilterAnimationController = ({ |
There was a problem hiding this comment.
const FilterAnimationController: React.FC<FilterAnimationControllerProps>
heshan0131
reviewed
Apr 20, 2022
src/components/bottom-widget.tsx
Outdated
| @@ -46,9 +53,23 @@ const BottomWidgetContainer = styled.div` | |||
| ${media.portable`padding: 0;`} | |||
| `; | |||
|
|
|||
| interface FilterAnimationControllerProps { | |||
| filter: TimeRangeFilter & {animationWindow?: string}; | |||
| children?: ReactNode; | |||
There was a problem hiding this comment.
you don't need children here when use the React.FC to define component as shown below
heshan0131
reviewed
Apr 20, 2022
src/components/bottom-widget.tsx
Outdated
| @@ -90,12 +111,24 @@ export function FilterAnimationControllerFactory(AnimationController: ReturnType | |||
| return FilterAnimationController; | |||
| } | |||
|
|
|||
| interface LayerAnimationControllerProps { | |||
| children?: ReactNode; | |||
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/js_to_ts_convertion_components_root_sp
branch
from
00c5553
to
160737a
Compare
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/js_to_ts_convertion_components_root_sp
branch
from
160737a
to
ed223e2
Compare
heshan0131
reviewed
Apr 28, 2022
| @@ -134,7 +134,7 @@ export const AnimationWindowControl = ({ | |||
| data-for={`${item.id}-tooltip`} | |||
| className="playback-control-button" | |||
| onClick={() => { | |||
| onClick&&onClick(item.id); | |||
| onClick && onClick(item.id); | |||
heshan0131
reviewed
Apr 29, 2022
| @@ -24,6 +24,16 @@ import {bindActionCreators} from 'redux'; | |||
| import {console as Console} from 'global/window'; | |||
| import KeplerGlContext from 'components/context'; | |||
|
|
|||
| export type FactoryElement = (...args) => React.Component; | |||
There was a problem hiding this comment.
shoud this be React.ComponentType instead of React.Component? so It also includes React.FC?
heshan0131
reviewed
Apr 29, 2022
| @@ -429,7 +480,7 @@ function KeplerGlFactory( | |||
| > | |||
| <NotificationPanel {...notificationPanelFields} /> | |||
| {!uiState.readOnly && !readOnly && <SidePanel {...sideFields} />} | |||
| <MapsLayout className="maps">{mapContainers}</MapsLayout> | |||
| <MapsLayout>{mapContainers}</MapsLayout> | |||
heshan0131
reviewed
Apr 29, 2022
|
|
||
| /** @type {{[key: string]: React.CSSProperties}} */ | ||
| const MAP_STYLE = { | ||
| container: { | ||
| display: 'inline-block', | ||
| position: 'relative', | ||
| position: 'relative' as Property.Position, |
There was a problem hiding this comment.
why adding individual type instead of use React.CSSProperties?
heshan0131
reviewed
Apr 29, 2022
| @@ -546,7 +589,7 @@ export default function MapContainerFactory(MapPopover, MapControl, Editor) { | |||
| mapIndex={index} | |||
| mapControls={mapControls} | |||
| readOnly={this.props.readOnly} | |||
| scale={mapState.scale || 1} | |||
| scale={1} | |||
There was a problem hiding this comment.
can we keep the mapState.scale here?
heshan0131
approved these changes
Apr 29, 2022
delete-merged-branch
bot
deleted the
dt/js_to_ts_convertion_components_root_sp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daria Terekhova daria.terekhova@actionengine.com