[Chore]: Technical: Translate deckgl-layers/layer-utils typesfix #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
heshan0131
reviewed
Apr 20, 2022
| aggregationUpdater: {}; | ||
|
|
||
| constructor(opts: {initialState?: CPUAggregatorState; dimensions?; aggregation?} = {}) { | ||
| dimensionUpdaters: DimensionType[]; |
There was a problem hiding this comment.
the original type is correct dimensionUpdaters is a key value map
heshan0131
reviewed
Apr 20, 2022
|
|
||
| this._addDimension(opts.dimensions || defaultDimensions); | ||
| this._addAggregation(opts.aggregation || defaultAggregation); | ||
| this.dimensionUpdaters = opts.dimensions || defaultDimensions; |
There was a problem hiding this comment.
remove the _addDimension will change the dimensionUpdaters to an array instead of an object
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
heshan0131
approved these changes
Apr 28, 2022
heshan0131
approved these changes
Apr 29, 2022
delete-merged-branch
bot
deleted the
ms/js_to_ts_convertion/deckgl-layers/typesfix_layer-utils
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.