[Chore]: Technical: add types for editor component #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariaterekhova-actionengine
force-pushed
the
dt/add-types-components-editor
branch
3 times, most recently
from
f0afc76
to
950312f
Compare
heshan0131
reviewed
Apr 29, 2022
src/components/editor/editor.tsx
Outdated
| layersToRender: Record<string, Layer>; | ||
| index: number; | ||
| className: string; // ?? | ||
| classnames: string; |
heshan0131
reviewed
Apr 29, 2022
src/components/editor/editor.tsx
Outdated
|
|
||
| export default function EditorFactory( | ||
| FeatureActionPanel: ComponentType<FeatureActionPanelProps> | ||
| ): ComponentType<EditorProps> { |
There was a problem hiding this comment.
should this be Reac.Component<EditorProps>?
There was a problem hiding this comment.
replaced by React.ComponentClass
heshan0131
reviewed
Apr 29, 2022
src/components/editor/editor.tsx
Outdated
|
|
||
| export default function EditorFactory( | ||
| FeatureActionPanel: ComponentType<FeatureActionPanelProps> |
There was a problem hiding this comment.
should this be React.FC<FeatureActionPanelProps>?
heshan0131
reviewed
Apr 29, 2022
| onClose: () => void; | ||
| } | ||
|
|
||
| export function PureFeatureActionPanelFactory(): ComponentType<FeatureActionPanelProps> { |
There was a problem hiding this comment.
const FeatureActionPanel: React.FC<FeatureActionPanelProps>
heshan0131
reviewed
Apr 29, 2022
| export interface FeatureActionPanelProps { | ||
| className?: string; | ||
| datasets: Datasets; | ||
| selectedFeature: Feature; |
There was a problem hiding this comment.
selectedFeature can be null
heshan0131
reviewed
Apr 29, 2022
| @@ -124,9 +132,9 @@ FeatureActionPanelFactory.deps = PureFeatureActionPanelFactory.deps; | |||
| export default function FeatureActionPanelFactory() { | |||
| const PureFeatureActionPanel = PureFeatureActionPanelFactory(); | |||
|
|
|||
| const ClickOutsideFeatureActionPanel = props => { | |||
| const ClickOutsideFeatureActionPanel = (props: FeatureActionPanelProps) => { | |||
There was a problem hiding this comment.
const ClickOutsideFeatureActionPanel: React.FC<FeatureActionPanelProps>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com> Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
jagerts
force-pushed
the
dt/add-types-components-editor
branch
from
ed3134f
to
50265d0
Compare
|
LGTM |
heshan0131
reviewed
May 14, 2022
src/components/editor/editor.tsx
Outdated
| state = { | ||
| showActions: false, | ||
| lastPosition: null | ||
| lastPosition: {x: 0, y: 0} |
There was a problem hiding this comment.
keep this as null
in feature-action-panel add
if (!position) {
return null
}
return (
<StyledActionsLayer
className={classnames('feature-action-panel', className)}
style={{
top: `${position.y + LAYOVER_OFFSET}px`,
left: `${position.x + LAYOVER_OFFSET}px`
}}
>
...
heshan0131
reviewed
May 14, 2022
| FeatureActionPanel.defaultProps = { | ||
| position: {} | ||
| position: {x: 0, y: 0} |
There was a problem hiding this comment.
make default position to be null. and return null in render if position is null
There was a problem hiding this comment.
fixed
also fixed a test for FeatureActionPanel, plz check it out
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
heshan0131
approved these changes
May 18, 2022
heshan0131
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daria Terekhova daria.terekhova@actionengine.com