[Chore]: Technical: Translate deckgl-layers/cluster-layer #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshan0131
reviewed
Jun 8, 2022
| import ClusterBuilder, {getGeoJSON} from '../layer-utils/cluster-utils'; | ||
| import {RGBAColor} from '../../reducers'; | ||
| import {AggregationLayerProps} from '@deck.gl/aggregation-layers/aggregation-layer'; |
There was a problem hiding this comment.
is this valid import from deck.gl? I think without a path resolver, you would always want to make deck.gl/aggregation-layers export AggregationLayerProps at top level and import from '@deck.gl/aggregation-layers
There was a problem hiding this comment.
That's import from npm package, not from deckgl-layers folder. So we can't do anything with the format there
heshan0131
approved these changes
Jun 8, 2022
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
ms/js_to_ts_convertion/deckgl-layers/cluster-layer
branch
from
8d67f36
to
8d44846
Compare
delete-merged-branch
bot
deleted the
ms/js_to_ts_convertion/deckgl-layers/cluster-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.