[Chore]: Technical: add types for side panel root components #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
jagerts
force-pushed
the
ez/add-types-side-panel-root
branch
from
d39075c
to
c22a144
Compare
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
heshan0131
reviewed
May 23, 2022
| type PanelToggleProps = { | ||
| panels: PanelItem[]; | ||
| activePanel: string; | ||
| togglePanel: typeof toggleSidePanel; |
There was a problem hiding this comment.
use ActionHandler<>
#1801 (comment)
heshan0131
reviewed
May 23, 2022
| const PanelToggle = ({activePanel, panels, togglePanel}) => { | ||
|
|
||
| function PanelToggleFactory(PanelTab: ReturnType<typeof PanelTabFactory>) { | ||
| const PanelToggle = ({activePanel, panels, togglePanel}: PanelToggleProps) => { |
There was a problem hiding this comment.
to be consistent...
const PanelToggle = React.FC<PanelToggleProps>
heshan0131
reviewed
May 23, 2022
| @@ -45,7 +62,7 @@ export const StyledPanelTab = styled.div.attrs({ | |||
| `; | |||
|
|
|||
| export function PanelTabFactory() { | |||
| const PanelTab = ({isActive, onClick, panel}) => ( | |||
| const PanelTab = ({isActive, onClick, panel}: PanelTabProps) => ( | |||
There was a problem hiding this comment.
const PanelTab: React.FC<PanelTabProps> = ({isActive, onClick, panel}) => ()
heshan0131
reviewed
May 23, 2022
| const dropdownItemsSelector = getDropdownItemsSelector(); | ||
|
|
||
| const SaveExportDropdown = props => ( | ||
| const SaveExportDropdown = (props: DropdownComponentProps) => ( |
There was a problem hiding this comment.
use SaveExportDropdown: React.FC<DropdownComponentProps>
heshan0131
reviewed
May 23, 2022
| const dropdownItemsSelector = getDropdownItemsSelector(); | ||
|
|
||
| const CloudStorageDropdown = props => ( | ||
| const CloudStorageDropdown = (props: DropdownComponentProps) => ( |
There was a problem hiding this comment.
use CloudStorageDropdown: React.FC<DropdownComponentProps>
heshan0131
reviewed
May 23, 2022
| @@ -86,7 +154,7 @@ const StyledToolbar = styled(Toolbar)` | |||
| position: absolute; | |||
| `; | |||
|
|
|||
| export const PanelAction = ({item, onClick}) => ( | |||
| export const PanelAction = ({item, onClick}: PanelActionProps) => ( | |||
There was a problem hiding this comment.
PanelAction: React.FC<PanelActionProps>
heshan0131
reviewed
May 23, 2022
| @@ -101,7 +169,7 @@ export const PanelAction = ({item, onClick}) => ( | |||
| ); | |||
|
|
|||
| export const PanelHeaderDropdownFactory = () => { | |||
| const PanelHeaderDropdown = ({items, show, onClose, id}) => { | |||
| const PanelHeaderDropdown = ({items, show, onClose, id}: PanelHeaderDropdownProps) => { | |||
There was a problem hiding this comment.
PanelHeaderDropdown: React.FC<PanelHeaderDropdownProps>
heshan0131
reviewed
May 23, 2022
| @@ -66,7 +96,7 @@ const LayerBlendingSelector = ({layerBlending, updateLayerBlending, intl}) => { | |||
| <FormattedMessage id="layerBlending.title" /> | |||
| </PanelLabel> | |||
| <ItemSelector | |||
| selectedItems={intl.formatMessage({id: LAYER_BLENDINGS[layerBlending].label})} | |||
| selectedItems={[intl.formatMessage({id: LAYER_BLENDINGS[layerBlending].label})]} | |||
There was a problem hiding this comment.
selectedItems don't need to be an array
heshan0131
reviewed
May 23, 2022
| filters: Filter[]; | ||
| datasets: Datasets; | ||
| layers: Layer[]; | ||
| showDatasetTable: typeof VisStateActions.showDatasetTable; |
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
heshan0131
approved these changes
Jun 1, 2022
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evgeny Zhgulev evgeny.zhgulev@actionengine.com