[Chore]: Technical: fix linting errors of @types/styled-components plugin #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
heshan0131
reviewed
May 23, 2022
| className: 'toolbar-item' | ||
| })<StyledDivProps>` | ||
| const StyledDiv = styled.div.attrs(props => ({ | ||
| className: `toolbar-item${props.className ? ` ${props.className}` : ''}` |
heshan0131
reviewed
May 23, 2022
| className: 'file-upload__progress' | ||
| })` | ||
| const StyledFileProgress = styled.div.attrs(props => ({ | ||
| className: `file-upload__progress${props.className ? ` ${props.className}` : ''}` |
heshan0131
reviewed
May 23, 2022
| color?: string; | ||
| label?: string; | ||
| }; | ||
| dataset: KeplerTable; |
There was a problem hiding this comment.
can we keep the original minified type?
There was a problem hiding this comment.
yes, we can. Fixed
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
heshan0131
reviewed
May 25, 2022
src/components/common/portaled.tsx
Outdated
| overlayZIndex?: number; | ||
| modalProps?: Partial<ReactModal.Props>; | ||
| modalStyle?: Partial<typeof defaultModalStyle>; | ||
| children: React.ReactNode; |
There was a problem hiding this comment.
shouldn't need to add children here
heshan0131
approved these changes
May 25, 2022
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
|
@heshan0131 i've merged all PR's about styled-components. So i added @types/styled-components and resolved some errors left in this pr. Check changes out, plz. |
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evgeny Zhgulev evgeny.zhgulev@actionengine.com