validate url of Add data modal #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jagerts
commented
May 26, 2022
jagerts
commented
- add removed styles of Add data modal
- add validation to url input
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
heshan0131
reviewed
Jun 1, 2022
examples/demo-app/src/utils/url.js
Outdated
| * @param str | ||
| */ | ||
| export function validateUrl(str) { | ||
| return str?.match(/^(ftp|https?):\/\/+(www\.)?[a-z0-9\-\.]{3,}\.[a-z]{3}$/); |
There was a problem hiding this comment.
should also allow http://
heshan0131
approved these changes
Jun 1, 2022
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
Signed-off-by: Evgeny Zhgulev <evgeny.zhgulev@actionengine.com>
eduramirezh
reviewed
Jun 4, 2022
| * @param str | ||
| */ | ||
| export function validateUrl(str) { | ||
| return str?.match(/^(ftp|http|https?):\/\/+(www\.)?[a-z0-9\-\.]{3,}\.[a-z]{3}$/); |
There was a problem hiding this comment.
This regex only allows URLs with an empty path (allows https://uber.com but not https://uber.com/data.csv).
Additionally, it removes the option of using localhost as a domain.
And TLDs with only 2 letters (.es, .cl, etc).
I think this PR should be reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.