[Chore]: Technical: Isolate deckgl-layers #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariaterekhova-actionengine
force-pushed
the
dt/deckgl_isolation
branch
from
8eca205
to
4b385de
Compare
heshan0131
reviewed
Jun 30, 2022
src/utils/export-utils.ts
Outdated
| @@ -36,6 +36,7 @@ import {set, generateHashId} from 'utils/utils'; | |||
|
|
|||
| import {createIndexedDataContainer} from './table-utils/data-container-utils'; | |||
| import {ExportImage} from 'reducers/ui-state-updaters'; | |||
| import { VisState } from 'reducers'; | |||
heshan0131
reviewed
Jul 6, 2022
src/deckgl-layers/babel.config.js
Outdated
| const PLUGINS = [ | ||
| ['@babel/plugin-transform-typescript', {isTSX: true, allowDeclareFields: true}], | ||
| '@babel/plugin-transform-modules-commonjs', | ||
| '@babel/plugin-proposal-export-namespace-from', |
There was a problem hiding this comment.
do you need this plugin?
heshan0131
reviewed
Jul 6, 2022
src/deckgl-layers/package.json
Outdated
| ], | ||
| "dependencies": { | ||
| "colorbrewer": "^1.5.0", | ||
| "d3-scale": "^3.2.3", |
There was a problem hiding this comment.
I would think you need lot os deck.gl dependencies from @deck.gl
heshan0131
approved these changes
Jul 6, 2022
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/package.json
Outdated
| "@mapbox/geo-viewport": "^0.4.1", | ||
| "@mapbox/vector-tile": "^1.3.1", | ||
| "@types/geojson": "^7946.0.7", | ||
| "colorbrewer": "^1.5.0", |
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/package.json
Outdated
| "@types/geojson": "^7946.0.7", | ||
| "colorbrewer": "^1.5.0", | ||
| "d3-array": "^2.8.0", | ||
| "d3-scale": "^3.2.3", |
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/package.json
Outdated
| "d3-scale": "^3.2.3", | ||
| "global": "^4.3.0", | ||
| "keymirror": "^0.1.1", | ||
| "react-map-gl-draw": "0.14.8", |
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/src/index.ts
Outdated
|
|
||
| export {default as EnhancedHexagonLayer} from './hexagon-layer/enhanced-hexagon-layer'; | ||
|
|
||
| export * from './layer-utils/cluster-utils'; |
There was a problem hiding this comment.
we don't need to export this
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/src/index.ts
Outdated
| @@ -0,0 +1,20 @@ | |||
| export {default as ThreeDBuildingLayer} from './3d-building-layer/3d-building-layer'; | |||
| export * from './3d-building-layer/3d-building-utils'; | |||
There was a problem hiding this comment.
we don't need to export this
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/src/index.ts
Outdated
| @@ -0,0 +1,20 @@ | |||
| export {default as ThreeDBuildingLayer} from './3d-building-layer/3d-building-layer'; | |||
| export * from './3d-building-layer/3d-building-utils'; | |||
| export * from './3d-building-layer/types'; | |||
There was a problem hiding this comment.
move type export to the bottom
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/src/index.ts
Outdated
| export {default as EnhancedHexagonLayer} from './hexagon-layer/enhanced-hexagon-layer'; | ||
|
|
||
| export * from './layer-utils/cluster-utils'; | ||
| export * from './layer-utils/cpu-aggregator'; |
There was a problem hiding this comment.
don't need to export this
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/src/index.ts
Outdated
| export * from './layer-utils/cpu-aggregator'; | ||
| export * from './layer-utils/shader-utils'; | ||
|
|
||
| export {default as EnhancedLineLayer} from './line-layer/line-layer'; |
There was a problem hiding this comment.
move all layer exports to the top
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/src/index.ts
Outdated
|
|
||
| export {default as EnhancedLineLayer} from './line-layer/line-layer'; | ||
|
|
||
| export * from './svg-icon-layer/scatterplot-icon-layer'; |
There was a problem hiding this comment.
don't need to export this
heshan0131
reviewed
Jul 7, 2022
src/deckgl-layers/src/index.ts
Outdated
| export {default as EnhancedLineLayer} from './line-layer/line-layer'; | ||
|
|
||
| export * from './svg-icon-layer/scatterplot-icon-layer'; | ||
| export {default as SvgIconLayer} from './svg-icon-layer/svg-icon-layer'; |
There was a problem hiding this comment.
move all layer export to the top
dariaterekhova-actionengine
force-pushed
the
dt/deckgl_isolation
branch
3 times, most recently
from
fb9d5e9
to
0caaa6c
Compare
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/deckgl_isolation
branch
from
0caaa6c
to
1fc175f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.