Chore: Fix lint script and issues #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrabinowitz
requested review from
macrigiuseppe,
heshan0131 and
dariaterekhova-actionengine
nrabinowitz
commented
Jul 19, 2022
| "no-undef": "off", | ||
| }, | ||
| }, | ||
| ], |
package.json
Outdated
| @@ -61,7 +61,7 @@ | |||
| "typedoc": "typedoc --theme markdown --out typedoc --inputFiles ./src/reducers --inputFiles ./src/actions --excludeExternals --excludeNotExported --excludePrivate", | |||
| "example-version": "babel-node ./scripts/edit-version.js", | |||
| "prettier-all": "prettier --write '{src,examples,test}/**/*.{js,tsx,ts}'", | |||
| "lint": "yarn typescript && eslint src/*/src/*.{js,tsx,ts} test webpack examples/*.js examples/**/src/*.{js,tsx,ts} website/*.js website/src --fix", | |||
| "lint": "yarn typescript && eslint src/*.js src/**/*.{js,tsx,ts} test webpack examples/*.js examples/**/src/*.{js,tsx,ts} website/*.js website/src --fix", | |||
There was a problem hiding this comment.
Note that for some reason just using src here caused yarn lint to run for several hours before I killed it - not sure why, but this seemed preferable.
|
The build failed lint with 220 additional errors, which I don't understand. Need to investigate why my local env is so different from CI, and then decide whether it's worth fixing all those errors now. |
added 3 commits
July 25, 2022 15:05
Signed-off-by: Nick Rabinowitz <nick@unfolded.ai>
Signed-off-by: Nick Rabinowitz <nick@unfolded.ai>
Signed-off-by: Nick Rabinowitz <nick@unfolded.ai>
nrabinowitz
changed the title
nrabinowitz
changed the title
jwasilgeo
approved these changes
Jul 26, 2022
heshan0131
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
yarn linthas not been checking files insrcsince this change. This fixes theyarn lintscript and addresses the lint failures it reveals.Some of these issues can be resolved by upgrading
eslint,prettier, and/oreslint-plugin-prettier, but for now this just gets lint green.