[Bug] Disable layer copy when layer is invalid #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jwasilgeo
commented
Jul 27, 2022
•
jwasilgeo
commented
- add allowDuplicate prop to layer header
- disable duplicate if layer is not valid
Signed-off-by: Jacob Wasilkowski <jwasilkowski@foursquare.com>
Signed-off-by: Jacob Wasilkowski <jwasilkowski@foursquare.com>
jwasilgeo
commented
Jul 27, 2022
jwasilgeo
commented
Jul 27, 2022
| @@ -140,6 +140,7 @@ function LayerPanelFactory( | |||
| const {layer, datasets, isDraggable, layerTypeOptions} = this.props; | |||
| const {config} = layer; | |||
| const {isConfigActive} = config; | |||
| const allowDuplicate = typeof layer.isValidToSave === 'function' && layer.isValidToSave(); | |||
There was a problem hiding this comment.
Originally via upstreaming this line was
const allowDuplicate = typeof layer.isValidToSave === 'function' && layer.isValidToSave() && isValid;but isValid now doesn't exist on the layer type definition. @heshan0131 do you think this diff will work as intended?
There was a problem hiding this comment.
make a note in [feat] Disable a layer after an error in Deck (#180) to address it when cherrypick
heshan0131
approved these changes
Jul 28, 2022
delete-merged-branch
bot
deleted the
jw/upstream-disable-layer-copy-when-layer-is-invalid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.