[Enhancement] set initial layer config when set layer type #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasilgeo
force-pushed
the
jw/upstream-enhancement-set-initial-layer-config-when-set-layer-type-43466a9
branch
from
c1d0d19
to
39f17e3
Compare
heshan0131
approved these changes
Aug 3, 2022
|
please make sure to remove (UN-1863) from the final squashed commit message |
igorDykhta
approved these changes
Aug 3, 2022
igorDykhta
requested changes
Aug 3, 2022
|
Same here...remove UN-1863 from squashed message |
jwasilgeo
force-pushed
the
jw/upstream-enhancement-set-initial-layer-config-when-set-layer-type-43466a9
branch
from
39f17e3
to
9c9bd1b
Compare
Signed-off-by: Shan He <heshan0131@gmail.com> [Bug] fix setting layer type override layer name Signed-off-by: Shan He <heshan0131@gmail.com> Signed-off-by: Jacob Wasilkowski <jwasilkowski@foursquare.com>
jwasilgeo
force-pushed
the
jw/upstream-enhancement-set-initial-layer-config-when-set-layer-type-43466a9
branch
from
9c9bd1b
to
d53ea5e
Compare
|
Good catch, I cleaned that up @heshan0131, thanks. |
Signed-off-by: Jacob Wasilkowski <jwasilkowski@foursquare.com>
igorDykhta
approved these changes
Aug 4, 2022
delete-merged-branch
bot
deleted the
jw/upstream-enhancement-set-initial-layer-config-when-set-layer-type-43466a9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shan He heshan0131@gmail.com
[Bug] fix setting layer type override layer name
Signed-off-by: Shan He heshan0131@gmail.com
Signed-off-by: Jacob Wasilkowski jwasilkowski@foursquare.com