[Chore]: Technical: Isolate reducers #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariaterekhova-actionengine
force-pushed
the
dt/reducers_isolations
branch
from
10df31e
to
22ecbb8
Compare
heshan0131
reviewed
Aug 31, 2022
src/components/map-container.tsx
Outdated
| @@ -67,15 +67,15 @@ import ErrorBoundary from 'components/common/error-boundary'; | |||
| import {LOCALE_CODES} from '@kepler.gl/localization'; | |||
| import {getMapLayersFromSplitMaps, onViewPortChange} from '@kepler.gl/utils'; | |||
| import {MapView} from '@deck.gl/core'; | |||
| import {MapStyle} from 'reducers'; | |||
| import {MapStyle} from '@kepler.gl/reducers'; | |||
heshan0131
reviewed
Aug 31, 2022
| @@ -0,0 +1,38 @@ | |||
| # Upgrade Guide (Data Containers) | |||
There was a problem hiding this comment.
why is this file moved?
heshan0131
reviewed
Aug 31, 2022
| @@ -51,10 +51,10 @@ import { | |||
| } from '@kepler.gl/constants'; | |||
| import {ExportFileToCloudPayload} from '@kepler.gl/types'; | |||
|
|
|||
| import {FILE_CONFLICT_MSG} from '../cloud-providers'; | |||
| import {FILE_CONFLICT_MSG} from 'cloud-providers'; | |||
heshan0131
reviewed
Aug 31, 2022
| @@ -28,9 +28,9 @@ import {console as Console} from 'global/window'; | |||
|
|
|||
| import {withState, injectComponents, PanelHeaderFactory} from 'components'; | |||
|
|
|||
| import {keplerGlReducerCore as coreReducer} from 'reducers'; | |||
| import {keplerGlReducerCore as coreReducer} from '@kepler.gl/reducers'; | |||
heshan0131
reviewed
Aug 31, 2022
| @@ -21,8 +21,8 @@ | |||
| /* eslint-disable max-statements */ | |||
|
|
|||
| import test from 'tape'; | |||
| import keplerGlReducer from 'reducers'; | |||
| import {addDataToMapUpdater, INITIAL_UI_STATE} from 'reducers'; | |||
| import keplerGlReducer from '@kepler.gl/reducers'; | |||
heshan0131
approved these changes
Aug 31, 2022
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/reducers_isolations
branch
from
22ecbb8
to
8edcc28
Compare
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daria Terekhova daria.terekhova@actionengine.com