[Chore]: Technical: Isolate components #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariaterekhova-actionengine
force-pushed
the
dt/components_isolation
branch
2 times, most recently
from
990ab41
to
77648f2
Compare
dariaterekhova-actionengine
force-pushed
the
dt/components_isolation
branch
2 times, most recently
from
128d809
to
c11286f
Compare
heshan0131
reviewed
Sep 4, 2022
| import {DEFAULT_TIME_FORMAT} from '@kepler.gl/constants'; | ||
| import {CenterFlexbox} from 'components/common/styled-components'; | ||
| import {CenterFlexbox} from '@kepler.gl/constants'; |
There was a problem hiding this comment.
styled-componets moved to constants? that seems a little odd
heshan0131
reviewed
Sep 4, 2022
| import {FormattedMessage} from '@kepler.gl/localization'; | ||
| import {Table} from 'components/common/icons'; | ||
| import {CenterFlexbox, Table} from '@kepler.gl/constants'; |
There was a problem hiding this comment.
instead of moving CenterFlexbox to constant, can you just copy the implementation here. so we don't need to have layers depends on CenterFlexbox?
Same for Table
heshan0131
reviewed
Sep 4, 2022
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| import React from 'react'; | |||
| import styled from 'styled-components'; | |||
| import {StyledTable as Table} from 'components/common/styled-components'; | |||
| import {StyledTable as Table} from '@kepler.gl/constants'; | |||
There was a problem hiding this comment.
looks like the only place StyledTable is used is in screnegraph-layer, you should just move the implementation in here, instead of moving it to constant
heshan0131
reviewed
Sep 4, 2022
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| import React, {Component} from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import Base from 'components/common/icons/base'; | |||
| import {Base} from '@kepler.gl/constants'; | |||
There was a problem hiding this comment.
can you make a copy of Base and put it inlayers/src/react and keep the Base in components/icons? so that we don't move it to constant?
There was a problem hiding this comment.
Base is imported by every other icon. So if we want at less one icon to be in @kepler.gl/constants then we need Base to be there as well
heshan0131
reviewed
Sep 4, 2022
src/constants/src/icons/index.ts
Outdated
| // eslint-disable-next-line prettier/prettier | ||
| export type {BaseProps} from './base'; | ||
| export {default as Upload} from './upload'; | ||
| export {default as Table} from './table'; |
There was a problem hiding this comment.
Move table into @kepler.gl/layers
heshan0131
reviewed
Sep 4, 2022
src/constants/src/icons/index.ts
Outdated
| export {default as Base} from './base'; | ||
| // eslint-disable-next-line prettier/prettier | ||
| export type {BaseProps} from './base'; | ||
| export {default as Upload} from './upload'; |
There was a problem hiding this comment.
Move upload into @kepler.gl/providers
dariaterekhova-actionengine
force-pushed
the
dt/components_isolation
branch
2 times, most recently
from
eccb928
to
72bba9c
Compare
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/components_isolation
branch
from
72bba9c
to
a8d161a
Compare
heshan0131
reviewed
Sep 8, 2022
| import {LayerHoverProp} from '@kepler.gl/reducers'; | ||
| import {} from '@kepler.gl/constants'; |
heshan0131
reviewed
Sep 8, 2022
test/helpers/mock-state.js
Outdated
| @@ -57,7 +57,7 @@ import { | |||
| import tripGeojson, {tripDataInfo} from 'test/fixtures/trip-geojson'; | |||
| import {processCsvData, processGeojson} from '@kepler.gl/processors'; | |||
| import {MOCK_MAP_STYLE} from './mock-map-styles'; | |||
| import {getUpdateVisDataPayload} from 'components/geocoder-panel'; | |||
| import {} from '@kepler.gl/components'; | |||
heshan0131
approved these changes
Sep 8, 2022
dariaterekhova-actionengine
force-pushed
the
dt/components_isolation
branch
from
a8d161a
to
d9af40d
Compare
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/components_isolation
branch
from
d9af40d
to
5f70170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.