Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Support async mergers #2129

Merged
merged 5 commits into from
Mar 1, 2023
Merged

[Feat] Support async mergers #2129

merged 5 commits into from
Mar 1, 2023

Conversation

igorDykhta
Copy link
Collaborator

  • upgrade react-palm
  • move code to merger-handler
  • handle mergeStateFromMergers
  • allow merge prop as an array
  • add test
  • add waitToFinish prop

Signed-off-by: Shan He heshan0131@gmail.com
Signed-off-by: Ihor Dykhta dikhta.igor@gmail.com

heshan0131 and others added 3 commits February 12, 2023 23:07
@heshan0131 @igorDykhta
Support async mergers
c11b43f 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
revert nit
3e81dee 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
ts and comments
7176926 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
remove ts expect error
54d1d4e 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
fix tests
ec1e473 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta merged commit 9d568af into master Mar 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the igr/support-async-mergers branch March 1, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heshan0131 heshan0131 heshan0131 approved these changes

@jwasilgeo jwasilgeo Awaiting requested review from jwasilgeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igorDykhta @heshan0131