Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add "No Basemap" option with map background color control #2136

Merged
merged 7 commits into from
Feb 27, 2023
Merged

[Feat] Add "No Basemap" option with map background color control #2136

merged 7 commits into from
Feb 27, 2023

Conversation

igorDykhta
Copy link
Collaborator

@igorDykhta igorDykhta commented Feb 20, 2023 •
edited

  • Changes UI by adding a new "No Basemap" option and a background color picker.
  • Changes the basemap map style change and map style loading redux updaters to accept an optional onSuccess callback in the action payload to allow for waiting on asynchronous basemap style load completion.
  • Changes to use deepmerge to merge state and mapState to include potential brand new state properties that didn't exist yet on previously saved projects.
  • Misc. localization readme docs typo fix.

manassra and others added 4 commits February 18, 2023 03:36
@manassra @igorDykhta
Request map styles on demand
18d99eb 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@ilyabo @igorDykhta
fixes the logic to set map overlay type properly when switching layer…
83e9a33 
… type

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
ts fixes
6495f53 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@jwasilgeo @igorDykhta
Add No Basemap option with map background color control
76a8ac2 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
panel label wrapper
bcd1abe 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
ts and nit
955e1f3 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@jwasilgeo
Copy link
Collaborator

jwasilgeo commented Feb 21, 2023 •
edited

@igorDykhta thanks for handling this one. I would recommend updating the PR description to something like the following:

  • Changes UI by adding a new "No Basemap" option and a background color picker.
  • Changes the basemap map style change and map style loading redux updaters to accept an optional onSuccess callback in the action payload to allow for waiting on asynchronous basemap style load completion.
  • Changes to use deepmerge to merge state and mapState to include potential brand new state properties that didn't exist yet on previously saved projects.
  • Misc. localization readme docs typo fix.

@igorDykhta
Copy link
Collaborator Author

igorDykhta commented Feb 27, 2023 •
edited

@igorDykhta thanks for handling this one. I would recommend updating the PR description to something like the following:

ooops, nice catch

@delete-merged-branch delete-merged-branch bot deleted the branch master February 27, 2023 15:18
@igorDykhta igorDykhta changed the base branch from igr/hover-support-fixes to master February 27, 2023 15:45
@igorDykhta igorDykhta merged commit e284800 into master Feb 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the igr/no-basemap-option-ex branch February 27, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasilgeo jwasilgeo jwasilgeo approved these changes

@heshan0131 heshan0131 Awaiting requested review from heshan0131

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@igorDykhta @jwasilgeo @manassra @ilyabo