Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Drag and drop interaction for split map #2172

Merged
merged 2 commits into from Apr 4, 2023

Conversation

igorDykhta
Copy link
Collaborator

@igorDykhta igorDykhta commented Mar 28, 2023

  1. replace react-sortable-hoc with dnd-kit. React-sortable-hoc is no longer actively maintained and its developers strongly encourage new consumers to adopt dnd-kit instead of adopting react-sortable-hoc.
  2. Add support for the split map mode, allowing dragging and dropping layers from the side panel to each of the two map panels.

albatross97 and others added 2 commits March 28, 2023 14:14
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Copy link
Collaborator

@ilyabo ilyabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 🚀

@igorDykhta igorDykhta merged commit 4dd27ab into master Apr 4, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the igr/drag-and-drop-interaction branch April 4, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants