Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] handle undefined values in updateViewport #2178

Merged
merged 2 commits into from Mar 30, 2023
Merged

[fix] handle undefined values in updateViewport #2178

merged 2 commits into from Mar 30, 2023

Conversation

igorDykhta
Copy link
Collaborator

  • prevent the passing of undefined values to Kepler state in updateViewport

kylebarron and others added 2 commits March 29, 2023 16:29
@kylebarron @igorDykhta
[fix] handle undefined values in updateViewport
44f0489 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
fix: handle undefined values in updateViewport
7167fb2 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta force-pushed the igr/upstream-handle-undefined-updateViewport branch from 7466cea to 7167fb2 Compare March 29, 2023 13:29
@igorDykhta igorDykhta merged commit 9057272 into master Mar 30, 2023
3 of 7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the igr/upstream-handle-undefined-updateViewport branch March 30, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasilgeo jwasilgeo jwasilgeo approved these changes

@ilyabo ilyabo Awaiting requested review from ilyabo

@heshan0131 heshan0131 Awaiting requested review from heshan0131

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@igorDykhta @jwasilgeo @kylebarron