[feat] Create layer correctly from saved layer config #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
ilyabo
approved these changes
Mar 30, 2023
| @@ -1186,6 +1186,175 @@ test('#visStateReducer -> DUPLICATE_LAYER', t => { | |||
| t.end(); | |||
| }); | |||
|
|
|||
| // TODO: not sure if this test is correct, it basically checks if the loaded visState is empty | |||
| // if we load configuration through the schema manager all layers will be changing from having visualChannels to visualConfig | |||
There was a problem hiding this comment.
Not sure where the test comes from, but maybe the goal is to make sure that an invalid layer wouldn't be loaded?
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
delete-merged-branch
bot
deleted the
igr/create-layer-from-saved-layer-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we load the layer correctly when using
createLayerFromConfig. We can now pass a parsed and loaded layer to the method