New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] hide pinned selection outline when layer is hidden #2181

Merged

igorDykhta merged 1 commit into master from igr/upst-hide-selection-outline

Apr 4, 2023

Collaborator

igorDykhta commented Mar 30, 2023

Add visible property to the hover layer that is tied to its main layer's visibility. This ensures that turning off the visibility of a layer will also hide any pinned map popover that has a highlight layer on the map, too.


          [Fix] hide pinned selection outline when layer is hidden

f25b27e

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>

igorDykhta requested review from ilyabo, heshan0131 and jwasilgeo

March 30, 2023 04:23

ilyabo approved these changes

View reviewed changes

Collaborator

ilyabo left a comment

lgtm 👍

igorDykhta merged commit 8589730 into master

7 checks passed

delete-merged-branch bot deleted the igr/upst-hide-selection-outline branch

April 4, 2023 17:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment