Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add display format setting for table/tooltip #2199

Merged
merged 3 commits into from Apr 18, 2023

Conversation

igorDykhta
Copy link
Collaborator

@igorDykhta igorDykhta commented Apr 16, 2023

Add a global “display formatter” that will be used to format the numeric and date-time values.

This global fomatter will be used as a “default formatter”, so users can set up and enable/disable the display format quickly. Besides, users will be able to customize the display format for each component on top of the global formatter (e.g. customize the display format for each column in the data table)

  • Table View

    • User can set display format for all integer/float/date columns at once
    • User can overwrite display format for each column
  • Tooltip

    • Use field.displayFormat instead of visState.interactionConfig.tooltips
    • User can overwrite display format for each field

lixun910 and others added 3 commits April 16, 2023 17:17
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Copy link
Collaborator

@ilyabo ilyabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@igorDykhta igorDykhta merged commit 3b73dc0 into master Apr 18, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the igr/ups-add-display-format-setting branch April 18, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants