[Fix] Feature Action Panel menu and editing tooltip are cut-off in dual map mode #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… map mode Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
ilyabo
approved these changes
May 22, 2023
There was a problem hiding this comment.
lgtm 👍
Side note: maybe we should consider using floating-ui for tooltips and popovers in kepler as well like in Studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shape selection/filter menu showing under the map on the right when in dual map mode.
The fix uses a react portal to change where that menu is inserted in the DOM. Instead of being nested inside the map on the left's DOM, it's appended to our context. That way it displays over both maps instead of being hidden by the left map.
switch the tooltip's position that shows on hover for shapes on the map. Too close to the right side - show the tooltip on the cursor's left side, etc.