Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] range slider doesn't work when step < 1 in dataset filter #2240

Merged
merged 1 commit into from Jun 9, 2023

Conversation

igorDykhta
Copy link
Collaborator

  • In the dataset filter, the value range could be small [-122.4548828, -122.4545319], which is common when e.g. filtering by latitude or longitude column. In this case, the range slider doesn't work correctly. It is caused by the normalizeSliderValue() function in range-brush.js, which works when step >= 1. When step < 1, the normalizeSliderValue() always returns a rounded value (or mark).

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta merged commit f562fbe into master Jun 9, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the igr/ups-range-slider-dsnt-work branch June 9, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants