Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Upgrade to react 18 #2323

Merged
merged 4 commits into from Sep 24, 2023
Merged

[chore] Upgrade to react 18 #2323

merged 4 commits into from Sep 24, 2023

Conversation

igorDykhta
Copy link
Collaborator

  • Upgrade to react 18

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@ilyabo
Copy link
Collaborator

ilyabo commented Sep 19, 2023

The React upgrade might bring deck/mapbox syncing lag. Do you experience it after the upgrade? If so, we should probably also upstream https://github.com/foursquare/kepler.gl/pull/723

@igorDykhta
Copy link
Collaborator Author

The React upgrade might bring deck/mapbox syncing lag. Do you experience it after the upgrade? If so, we should probably also upstream foursquare/kepler.gl#723

The PR is scheduled for upstreaming.

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta merged commit a0e5db7 into master Sep 24, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the igr/ups-react-18 branch September 24, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants