[fix] Layer column config: sometimes a suggested field pair will hard crash #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… crash Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
jwasilgeo
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a hard crash that can occur when the user selects a suggested field pair for a layer geometry column that would lead to an
undefinedcolumn in the base layerassignColumnPairsmethod.The solution adds an additional short-circuit in the base layer method
assignColumnPairsif that is the case, but more importantly also first prevents the UI from providing invalid suggested field pair choices that would lead to this condition.Adds a couple of test cases to help document to devs what the underlying
findPointFieldPairsdata method is intended to do.