Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Avoid confusion in viewstate context #2361

Merged
merged 1 commit into from Oct 10, 2023

Conversation

igorDykhta
Copy link
Collaborator

MapViewStateContext sometimes stores complete mapState, sometimes only viewport. This changes it so that MapViewStateContext only keeps the viewport with the other props stripped out, and we merge it with mapState where it is needed.

Also, renaming getViewportFromMapState in map-state-updaters.ts into pickViewportPropsFromMapState to avoid confusion with another function with the same name.

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta merged commit d0a8658 into master Oct 10, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the igr/ups-viewstate-impr-1 branch October 10, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants