Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Export effects types/utils and incapsulate dnd logic into new hooks #2384

Merged
merged 3 commits into from Oct 20, 2023
Merged

[chore] Export effects types/utils and incapsulate dnd logic into new hooks #2384

merged 3 commits into from Oct 20, 2023

Conversation

igorDykhta
Copy link
Collaborator

PR description

  • exported effect types/utils
  • incapsulated logic for dnd into hooks to be reused in studio
  • created tests for new hooks

@macrigiuseppe @igorDykhta
[chore] Export effects types/utils and incapsulate dnd logic into new…
3b047d2 
… hooks

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
try to fix tests
6400ac1 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
adjust mocks
d15b27b 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta merged commit 08492a8 into master Oct 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyabo ilyabo ilyabo approved these changes

@jwasilgeo jwasilgeo Awaiting requested review from jwasilgeo

@macrigiuseppe macrigiuseppe Awaiting requested review from macrigiuseppe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@igorDykhta @ilyabo @macrigiuseppe