Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Hexbin layer color aggregation incorrect on load #2415

Merged
merged 1 commit into from Oct 28, 2023

Conversation

igorDykhta
Copy link
Collaborator

@igorDykhta igorDykhta commented Oct 25, 2023

PR Description

  • Fixes loading cycle layer validation in vis state mergers by moving validateSavedVisualChannels() to be done after newLayer.validateVisConfig() and newLayer.updateLayerConfig().

    Specifically, I found that when loading a Hexbin layer with a saved config color aggregation mode of count unique, the visual channel color aggregation would be incorrectly validated and set with options that do not work together, first without enough of the saved config included to help it understand which field type, color scale, and aggregation mode should be used, despite the saved config information being correct from the previous session. This change does the visual channel validation after all saved config information is mixed into the newLayer.

  • Improves aggregation dropdown UI to use more human-friendly options to display to the user.

  • Bonus: Improves displayed instruction text above the layer configurator aggregation type selector UI, so that it uses the selected field's displayName instead of raw name.

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta igorDykhta merged commit b995c9b into master Oct 28, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the igr/ups-hexbin-aggregation-fix branch October 28, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants