New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Legend is rendered outside of widget #2417

Merged

igorDykhta merged 1 commit into master from igr/ups-legend-root-context

Oct 28, 2023

Collaborator

igorDykhta commented Oct 25, 2023

In certain cases, Legend can be rendered outside of the widget. This PR fixes the issue by using rootContext for the portal when rendering the legend.


          [fix] Legend is rendered outside of widget

a629419

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>

igorDykhta requested review from ilyabo and jwasilgeo

October 25, 2023 21:09

ilyabo approved these changes

View reviewed changes

igorDykhta merged commit 5e0ad51 into master

8 checks passed

delete-merged-branch bot deleted the igr/ups-legend-root-context branch

October 28, 2023 00:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment