[fix] Fixed website configuration to correctly import local kepler files #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrigiuseppe
force-pushed
the
fix_website_webpack
branch
from
480aaae
to
bc83b79
Compare
macrigiuseppe
commented
Nov 21, 2023
Comment on lines
+8
to
+44
| const resolveAlias = { | ||
| react: `${NODE_MODULES_DIR}/react`, | ||
| 'react-dom': `${NODE_MODULES_DIR}/react-dom`, | ||
| 'react-redux': `${NODE_MODULES_DIR}/react-redux/lib`, | ||
| 'styled-components': `${NODE_MODULES_DIR}/styled-components`, | ||
| 'react-intl': `${NODE_MODULES_DIR}/react-intl`, | ||
| // Suppress useless warnings from react-date-picker's dep | ||
| 'tiny-warning': `${SRC_DIR}/utils/src/noop.ts` | ||
| }; | ||
|
|
||
| // add kepler.gl submodule aliases | ||
| const workspaces = KeplerPackage.workspaces; | ||
| workspaces.forEach(workspace => { | ||
| // workspace = "./src/types", "./src/constants", etc | ||
| const moduleName = workspace.split('/').pop(); | ||
| resolveAlias[`@kepler.gl/${moduleName}`] = join(SRC_DIR, `${moduleName}/src`); | ||
| }); |
There was a problem hiding this comment.
this part makes sure to generate the correct aliases for examples and website
macrigiuseppe
commented
Nov 21, 2023
Comment on lines
+27
to
+28
| const LIB_DIR = resolve(__dirname, '..'); | ||
| const SRC_DIR = resolve(LIB_DIR, './src'); |
There was a problem hiding this comment.
made them consistent with the examples/webpack.config.local.js
Signed-off-by: Giuseppe Macri <gmacri@foursquare.com>
macrigiuseppe
force-pushed
the
fix_website_webpack
branch
from
bc83b79
to
01c3a24
Compare
macrigiuseppe
commented
Nov 21, 2023
Comment on lines
+86
to
+88
| test: /\.mjs$/, | ||
| include: /node_modules\/apache-arrow/, | ||
| type: 'javascript/auto' |
There was a problem hiding this comment.
this makes sure apache arrow files are imported correctly. copied from examples/webpack.config.local.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website webpack configuration was loading kepler.gl files node_modules rather than local src files.
This PR makes sure the correct aliases (copied from examples webpack config) are used.
I combined several webpack configuration variables into one shared file