Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloud tile fetching logic #2456

Merged
merged 4 commits into from Nov 24, 2023
Merged

Fix cloud tile fetching logic #2456

merged 4 commits into from Nov 24, 2023

Conversation

macrigiuseppe
Copy link
Collaborator

@macrigiuseppe macrigiuseppe commented Nov 21, 2023 •
edited

This PR fixe:

  • issue with provider tile fetching login
  • issue when loading a map from a provider and updating the URL

fix_cloud_tile_fetching_logic

@macrigiuseppe macrigiuseppe marked this pull request as draft November 21, 2023 19:51
fix cloud tile fetching logic
33fbca0 
Signed-off-by: Giuseppe Macri <gmacri@foursquare.com>
use window.location.origin as redirect_uri
09ea5bf 
Signed-off-by: Giuseppe Macri <gmacri@foursquare.com>
@macrigiuseppe macrigiuseppe marked this pull request as ready for review November 22, 2023 14:45
fixed logic to load maps
4c021b1 
Signed-off-by: Giuseppe Macri <gmacri@foursquare.com>
igorDykhta
igorDykhta approved these changes Nov 22, 2023
View reviewed changes
examples/demo-app/src/actions.js Outdated
const mapUrl = provider.getMapUrl(false, loadParams);
dispatch(push(mapUrl));
const mapUrl = provider?.getMapUrl(loadParams);
debugger;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove debugger;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course

remoed debugger message
047b8bc 
Signed-off-by: Giuseppe Macri <gmacri@foursquare.com>
@macrigiuseppe macrigiuseppe merged commit 155a582 into master Nov 24, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix_cloud_tile_fetching_logic branch November 24, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorDykhta igorDykhta igorDykhta approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macrigiuseppe @igorDykhta