Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin luma.gl version to 8.5.21, to avoid mismatch #2463

Merged
merged 2 commits into from Dec 18, 2023

Conversation

birkskyum
Copy link
Collaborator

@birkskyum birkskyum commented Nov 30, 2023

Stumbled upon a version mismatch with luma as part of #2461 , because it's pinned in the "resolutions" part of package.json. Thus just update to the latest 8.x release.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Birk Skyum <birk.skyum@pm.me>
Signed-off-by: Birk Skyum <birk.skyum@pm.me>
@birkskyum
Copy link
Collaborator Author

Rebased - after loaders.gl was updated to 4.0 alpha.3 on master branch.

@birkskyum birkskyum merged commit b290d87 into keplergl:master Dec 18, 2023
7 checks passed
@birkskyum birkskyum mentioned this pull request Dec 18, 2023
chrisgervang pushed a commit to chrisgervang/kepler.gl that referenced this pull request Dec 19, 2023
* pin luma.gl version to 8.5.21, to avoid mismatch

Signed-off-by: Birk Skyum <birk.skyum@pm.me>

* yarn

Signed-off-by: Birk Skyum <birk.skyum@pm.me>

---------

Signed-off-by: Birk Skyum <birk.skyum@pm.me>
Signed-off-by: Chris Gervang <chris@gervang.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants