[Fix] GeoArrow demo not working #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Li <lixun910@gmail.com>
|
OK. This PR fixes the issue. It's working on staging now: https://deploy-preview-2491--keplergl.netlify.app/demo/nyc_earnings |
ibgreen
approved these changes
Dec 20, 2023
| @@ -83,8 +83,6 @@ function makeLocalDevConfig(env, EXAMPLE_DIR = LIB_DIR, externals = {}) { | |||
| externals['loaders.gl'].forEach(mdl => { | |||
| resolveAlias[`@loaders.gl/${mdl}`] = `${EXTERNAL_LOADERS_SRC}/modules/${mdl}/src`; | |||
| }); | |||
| // kepler.gl and loaders.gl need to use same apache-arrow | |||
| resolveAlias['apache-arrow'] = resolve(__dirname, '../node_modules/apache-arrow'); | |||
There was a problem hiding this comment.
So package.json "resolutions" are not enough?
There was a problem hiding this comment.
Thanks, Ib! good point. Let me try it quickly.
There was a problem hiding this comment.
Just tested it: seems package.json "resolutions" are not enough.
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new GeoArrow sample seems not working on kepler.gl site. From the log, it seems different
apache-arrowmodules have been used and caused the error. This PR tries to fix this.