[Refactor] Unnecessary ternary #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced unnecessary ternary expression
|
This change is unnecessary, |
|
Thanks for the reply! Oh I see why, now that I think of it a second time. However, I could not find a test log, is there a way to show the log in the Travis CI Build? |
|
Yes, you can click on the job id https://travis-ci.com/uber/kepler.gl/jobs/161083310 |
igorDykhta
added a commit
that referenced
this pull request
Aug 5, 2022
- reset clicked and hover values for a layer affected by LAYER_TYPE_CHANGE
igorDykhta
added a commit
that referenced
this pull request
Aug 5, 2022
- reset clicked and hover values for a layer affected by LAYER_TYPE_CHANGE Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
igorDykhta
added a commit
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced unnecessary ternary expression