[Feat] upgrade to deck.gl@8 #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshan0131
force-pushed
the
gpu-data-filter-6
branch
from
32a8a06
to
c999520
Compare
25 tasks
Closed
add @luma.gl/test-utils fix h3 layer color, update aggregation with latest aPI Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
| @@ -240,6 +240,7 @@ export default class ArcLayer extends Layer { | |||
| getFilterValue: gpuFilter.filterValueUpdateTriggers, | |||
| getWidth: { | |||
| sizeField: this.config.sizeField, | |||
| sizeScale: this.config.sizeScale, | |||
There was a problem hiding this comment.
is this property now available on the layer side panel?
| pointRadiusScale: radiusScale, | ||
| lineMiterLimit: 4 | ||
| }; | ||
|
|
||
| const updateTriggers = { | ||
| getElevation: { | ||
| heightField: this.config.heightField, | ||
| heightScale: this.config.heightScale, | ||
| heightScaleType: this.config.heightScale, |
There was a problem hiding this comment.
new naming convention?
There was a problem hiding this comment.
this is just to avoid conflict with deck.gl layer props, for updateTriggers it doesn't really matter of the name, becuase it's a shallow comparison between newUpdateTriggers. heightScaleType and oldUpdateTriggers. heightScaleType
| @@ -126,7 +128,7 @@ export default class HexagonIdLayer extends Layer { | |||
|
|
|||
| for (let i = 0; i < filteredIndex.length; i++) { | |||
| const index = filteredIndex[i]; | |||
| const id = getHexId(allData[index]); | |||
| const id = getHexId({data: allData[index]}); | |||
There was a problem hiding this comment.
@macrigiuseppe update s2 layer
|
|
||
| // save a reference of centroids to dataToFeature | ||
| // so we don't have to re calculate it again | ||
| centroids[index] = getCentroid({id}); | ||
| return getCentroid({id}); | ||
| }); | ||
|
|
||
| const bounds = this.getPointsBounds(Object.values(centroids), d => d); |
There was a problem hiding this comment.
isn't centroids an array already?
src/layers/layer-text-label.js
Outdated
| : textLabel.size; | ||
|
|
||
| const pixelRadius = radiusScale * distanceScale.pixelsPerMeter[0]; | ||
| const padding = 20; |
There was a problem hiding this comment.
constant, define it outside the function
macrigiuseppe
approved these changes
Feb 18, 2020
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shan He heshan0131@gmail.com