Refactor cli to avoid double args parsing #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New command module interface: instead of 'run' function they must have 'command' function that accepts flags table and other arguments. For compatibility a new util function is called on all command modules: it adds 'run' function that parses command-line args before passing them to 'command'.
Use 'commands' functions directly.
|
@hishamhm the comment about 'run' interface being used by other programs is four years old, do you know if it's still true? |
|
afaict it is a reference to I use a patched variant to automate luarocks commands in loverocks (example), but I am perfectly okay with my abuse of internal APIs breaking. The proposed patch seems easy enough to feature-detect. |
|
@hishamhm done! |
|
awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of 'run' function command modules now have 'command' function that accepts already parsed flags. Code mutating original args in 'luarocks.command_line' and 'util.forward_flags' are no longer needed.
There was a comment saying that the old 'run' interface, although undocumented, is used by some people. It may be irrelevant now but I've added an utility function wrapping the new interface to provide 'run'. It's called on all command modules.