Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new keploy-config #280

Merged
merged 4 commits into from
Dec 9, 2023
Merged

fix: add new keploy-config #280

merged 4 commits into from
Dec 9, 2023

Conversation

AkashKumar7902
Copy link
Member

Pull Request Template

Description

the code snippets in configuration-file page were outdated and needed an update.

Fixes # (keploy/keploy#1180)

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
@AkashKumar7902
Copy link
Member Author

hold the merge !

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
@Shashwat79802
Copy link
Contributor

Can you please fix the spacing and match it with the above code blocks
image
image

…ets'

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Conflicts:
	versioned_docs/version-2.0.0/running-keploy/configuration-file.md
@AkashKumar7902
Copy link
Member Author

@Shashwat79802 can you please tell me the line number ?
it looks like this to me:
image

@Shashwat79802
Copy link
Contributor

@Shashwat79802 can you please tell me the line number ?
it looks like this to me:
image

The spacing given in second code block is more than the spacing in first code block, so I was talking about reducing it and matching it with the first one!!

@Shashwat79802
Copy link
Contributor

Looks good!!

@nehagup nehagup merged commit 219808b into main Dec 9, 2023
1 check passed
@nehagup nehagup deleted the update-code-snippets branch December 9, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants