feat: Implemented build checks using Github Actions for Go-SDK #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanjasir90 <khanmohdjasir@gmail.com>
|
@slayerjain after rebase build works properly though tests are failing due to some connection error could u pls look into that |
|
@slayerjain ig we should remove the test job for the time being! since the pr is focused on build. what are ur thoughts on this. |
|
@khanjasir90 We are planning to add tests in coming future, so it would be good to keep it. Give me sometime. I’ll look into this error |
|
Got it! |
…r90/added-build-checks-using-github-actions
slayerjain
added a commit
that referenced
this pull request
Sep 12, 2022
I'm commenting tests with require mocking so that tests can pass. We uncovered this issue when we tried to add a build pipeline - which includes go test in #125 Signed-off-by: slayerjain <shubhamkjain@outlook.com>
slayerjain
added a commit
that referenced
this pull request
Sep 12, 2022
I'm commenting tests with require mocking so that tests can pass. We uncovered this issue when we tried to add a build pipeline - which includes go test in #125 Signed-off-by: slayerjain <shubhamkjain@outlook.com> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
|
@khanjasir90 please rebase with the |
|
@slayerjain will do it asap! |
|
@slayerjain it works 👍! go test now works! now we can add more strict i.e min 2 reviews required before merge ! |
|
@khanjasir90 yes, this look perfect. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: khanjasir90 khanmohdjasir@gmail.com
Implemented build checks using github actions for go-sdk