feat(pre-commit-hook & contribution guid) : Added support for gofmt pre-commit hook & updated contribution.md file with all the steps to make the contribution.

[khanjasir90]

Added pre-comit hook in .githook folder which would check for changes and accordingly format the gofiles with gofmt package.
also added the screen-shot of working githook in my local machine.

[khanjasir90]

@slayerjain @nehagup added the pre-commit hook pls go through it once whenever u r free.

[slayerjain]

@khanjasir90 thanks for the PR!

This doesn't seem to work on my machine. I think the reason is because you are not using the default hooks path ($GIT_DIR/hooks) as mentioned here - https://git-scm.com/docs/githooks#_description

Although there's an option for changing the git hooks path, I'm not if the default path is a problem.

[khanjasir90]

actually u need to configure it to the .githooks path by executing this command "git config core.hooksPath .githooks" and after that it will work

[slayerjain]

Yes, but why not just use the default path? This way contributors don’t need to perform this additional step.

[khanjasir90]

actually @slayerjain the thing is that git doesn't track the .git folder so the changes made to .git folder will not be available to the contributors!
So what I have decided is to update/create a new contributing.md file where will cover all the things from cloning the repo to raising a PR all steps will be covered including the above one! So it will help the contributors and make their task easy

[khanjasir90]

@slayerjain does the above idea sounds good ? if not we can figure out something else.

[slayerjain]

@khanjasir90 you have valid points. I'm looking into this.

[khanjasir90]

okay! @slayerjain

[slayerjain]

@khanjasir90 I agree with your solution. 👍

we'll have to manually configure the client-side hooks. So I think we can mention this in the contributing guide. Please update the PR with the guide, then we can merge it :)

[khanjasir90]

ya sure i'll do the needfull in contributing.md i will cover all the steps of creating a PR from forking the repo to pushing the code is that okay with you!

[slayerjain]

@khanjasir90 yep, sounds good

[khanjasir90]

@slayerjain please go through this in ur free time and let me know if all things are good or any change needs to be made.

[slayerjain]

We also need to give the scripts inside .githooks permission for execution. So this line can become git config core.hooksPath .githooks && chmod +x .githooks/*

[khanjasir90]

okay will do the needfull!

[slayerjain]

Please add the line to include permissions in the contributing guide

[slayerjain]

@nehagup What do you think about the changes to the contribution guide?

[khanjasir90]

updated contribution.md file with permission scripts.

[nehagup]

LGTM 👏

Thanks for contributing @khanjasir90 ! 💫