Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Keploy test should throw non-zero exit code to notify the GitHub action #1244

Closed
1 task done
re-Tick opened this issue Dec 24, 2023 · 3 comments · Fixed by #1366
Closed
1 task done

[feature]: Keploy test should throw non-zero exit code to notify the GitHub action #1244

re-Tick opened this issue Dec 24, 2023 · 3 comments · Fixed by #1366
Labels
Enhancement New feature or request keploy

Comments

@re-Tick
Copy link
Contributor

re-Tick commented Dec 24, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Summary

Currently, keploy test returns a zero exit code on test failure due to which the GitHub action is not notified for test run failure. Instead it can return 1 as exit code if the test run fails.

Why should this be worked on?

This will notify the GitHub action in the CI of the user.

Repository

keploy

@re-Tick re-Tick added the Enhancement New feature or request label Dec 24, 2023
@Akash-Singh04
Copy link
Contributor

Akash-Singh04 commented Jan 8, 2024

Hey there! I would love to pick up this issue. Can you provide more information regarding where the exit code returns 0? Thanks

CC: @re-Tick

@seipan
Copy link
Contributor

seipan commented Jan 10, 2024

Hello, @re-Tick. Regarding this issue, I believe it can be resolved by modifying t.tester.Test to return 1 when the bool return value is false. If this approach seems appropriate, I am ready to submit a pull request for your consideration. Thank you.

https://github.com/keploy/keploy/blob/main/cmd/test.go#L273"

@re-Tick
Copy link
Contributor Author

re-Tick commented Jan 15, 2024

Hello, @re-Tick. Regarding this issue, I believe it can be resolved by modifying t.tester.Test to return 1 when the bool return value is false. If this approach seems appropriate, I am ready to submit a pull request for your consideration. Thank you.

https://github.com/keploy/keploy/blob/main/cmd/test.go#L273"

Yes @seipan, your approach is right. You can make the changes and open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request keploy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants