Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Implement Non-Zero Exit Code for Keploy Test Failures #1366

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

seipan
Copy link
Contributor

@seipan seipan commented Jan 15, 2024

Related Issue

  • Info about Issue or bug

Closes: #1244

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: seipan <yamasakipann0218@gmail.com>
Copy link

github-actions bot commented Jan 15, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@seipan
Copy link
Contributor Author

seipan commented Jan 15, 2024

I have read the CLA Document and I hereby sign the CLA

@seipan
Copy link
Contributor Author

seipan commented Jan 15, 2024

@re-Tick Please take a look!

cmd/test.go Outdated Show resolved Hide resolved
Signed-off-by: seipan <yamasakipann0218@gmail.com>
@seipan seipan requested a review from re-Tick January 16, 2024 16:13
@seipan
Copy link
Contributor Author

seipan commented Jan 16, 2024

@re-Tick
I've made the requested changes and updated the PR. Please review. Thank you!

@re-Tick
Copy link
Contributor

re-Tick commented Jan 22, 2024

LGTM

@re-Tick re-Tick merged commit b557ded into keploy:main Jan 24, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@slayerjain
Copy link
Member

Thanks for the PR @seipan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Keploy test should throw non-zero exit code to notify the GitHub action
3 participants