Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: only add sudo to docker alias for linux if required #1469

Closed
1 task done
slayerjain opened this issue Jan 31, 2024 · 2 comments · Fixed by #1492
Closed
1 task done

[bug]: only add sudo to docker alias for linux if required #1469

slayerjain opened this issue Jan 31, 2024 · 2 comments · Fixed by #1492
Labels
bug Something isn't working keploy

Comments

@slayerjain
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

By default docker requires using sudo in most linux distros. There are ways to avoid adding the sudo flag everytime. Keploy should check if docker is executable without sudo and use the alias (used during installation accordingly"

Steps to reproduce

  1. install keploy on linux select docker using - curl -O https://raw.githubusercontent.com/keploy/keploy/main/keploy.sh && source keploy.sh
  2. keploy will ask for sudo everytime. can be verified with alias docker

Environment

None

Version

Cloud

Repository

keploy

@slayerjain slayerjain added the bug Something isn't working label Jan 31, 2024
@Akash-Singh04
Copy link
Contributor

Hey, I would like to work on this!

@Akash-Singh04
Copy link
Contributor

@slayerjain Kindly review the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keploy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants