Updated Docker Installation Alias for linux

[Akash-Singh04]

Related Issue

• Only add sudo to docker alias for linux if required

Closes: #1469

Describe the changes you've made

• We check if docker ps runs successfully without sudo.
• If it does, the alias is created without sudo, otherwise, it's created with sudo, otherwise not

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, local variables)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Please let us know if any test cases are added

NIL

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NIL

Checklist:

• My code follows the style guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.

[Akash-Singh04]

@slayerjain Kindly look into this PR for the issue you opened

[slayerjain]

@Akash-Singh04 thanks for the PR.

@PranshuSrivastava since you were working on this script, can you please and test this?

[PranshuSrivastava]

Hey @Akash-Singh04, thanks for the PR. But this is not a good solution for the problem. This is kind of a hack to check if docker runs with sudo or not. So in macos sudo is generally not required, but in linux sudo is required but it can be removed with a specific configuration. So take a look at how the need for sudo is removed in Linux, and check if the user's system has that configuration or not, and if it does then don't use sudo

[Akash-Singh04]

Hey @Akash-Singh04, thanks for the PR. But this is not a good solution for the problem. This is kind of a hack to check if docker runs with sudo or not. So in macos sudo is generally not required, but in linux sudo is required but it can be removed with a specific configuration. So take a look at how the need for sudo is removed in Linux, and check if the user's system has that configuration or not, and if it does then don't use sudo

In this updated implementation, we check if the current user belongs to the docker group using the groups command since users inside the docker group have permission to run docker without the sudo command

Reference: https://askubuntu.com/a/477554

@PranshuSrivastava Kindly check this implementation and let me know if it is an optimal solution. If you have any other resources that are viable to this issue, kindly share.

[PranshuSrivastava]

The rest of the changes look good, there is just one comment that you need to address.

[PranshuSrivastava]

use else if here, we are doing this specifically on linux

[Akash-Singh04]

Kindly check if this was the intended change

[PranshuSrivastava]

LGTM