Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: log error in case of invalid flags #1747

Closed
1 task done
shivamsouravjha opened this issue Mar 28, 2024 · 2 comments · Fixed by #1753
Closed
1 task done

[feature]: log error in case of invalid flags #1747

shivamsouravjha opened this issue Mar 28, 2024 · 2 comments · Fixed by #1753
Labels
Enhancement New feature or request Go Pull requests that update Go code Good First Issue Good for newcomers

Comments

@shivamsouravjha
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Summary

  • Incase of running invalid flags keploy doesn't specifically tells the error just stops.
image

Why should this be worked on?

  • Incase if an invalid flag is provided, it should be logged as well for the user

Repository

keploy
@shivamsouravjha shivamsouravjha added the Enhancement New feature or request label Mar 28, 2024
@shivamsouravjha shivamsouravjha added Good First Issue Good for newcomers Go Pull requests that update Go code and removed keploy labels Mar 28, 2024
@ethanwater
Copy link
Contributor

Gonna give this a look. 👍

This was referenced Mar 28, 2024
Closed
Merged
@ethanwater
Copy link
Contributor

@shivamsouravjha This bug has been fixed. The errors were being explicitly silenced.

slayerjain pushed a commit that referenced this issue Mar 30, 2024
@ethanwater
fix: #1747 enable error logging for invalid flags (#1753)
16eacd7 
* display invalid-flags for record + error handling for ValidateFlags

Signed-off-by: Ethan Water <angelshatepop@gmail.com>

* cleanup

Signed-off-by: Ethan Water <angelshatepop@gmail.com>

* aesthetic error output

Signed-off-by: Ethan Water <watermonic@gmail.com>

* remove redundant logging

Signed-off-by: Ethan Water <watermonic@gmail.com>

* remove redundant code/ be nice to the linter!

Signed-off-by: Ethan Water <watermonic@gmail.com>

* replaced unused arg with _

Signed-off-by: Ethan Water <watermonic@gmail.com>

---------

Signed-off-by: Ethan Water <angelshatepop@gmail.com>
Signed-off-by: Ethan Water <watermonic@gmail.com>
gouravkrosx pushed a commit that referenced this issue Jun 10, 2024
@ethanwater
fix: #1747 enable error logging for invalid flags (#1753)
44c02b9 
* display invalid-flags for record + error handling for ValidateFlags

Signed-off-by: Ethan Water <angelshatepop@gmail.com>

* cleanup

Signed-off-by: Ethan Water <angelshatepop@gmail.com>

* aesthetic error output

Signed-off-by: Ethan Water <watermonic@gmail.com>

* remove redundant logging

Signed-off-by: Ethan Water <watermonic@gmail.com>

* remove redundant code/ be nice to the linter!

Signed-off-by: Ethan Water <watermonic@gmail.com>

* replaced unused arg with _

Signed-off-by: Ethan Water <watermonic@gmail.com>

---------

Signed-off-by: Ethan Water <angelshatepop@gmail.com>
Signed-off-by: Ethan Water <watermonic@gmail.com>
Former-commit-id: 16eacd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Go Pull requests that update Go code Good First Issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug fix/1747. enable error logging for invalid flags ethanwater/keploy
2 participants
@shivamsouravjha @ethanwater